Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing PUT calls to PATCH call #7946

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Changing PUT calls to PATCH call #7946

merged 5 commits into from
Sep 5, 2024

Conversation

jaskisin
Copy link
Contributor

@jaskisin jaskisin commented Sep 4, 2024 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az workloads

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 4, 2024 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test
❌workloads
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update removed parameter configuration please add back parameter configuration for cmd workloads sap-virtual-instance update
❌ 1007 - ParaRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update removed parameter generic_update_add please add back parameter generic_update_add for cmd workloads sap-virtual-instance update
❌ 1007 - ParaRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update removed parameter generic_update_force_string please add back parameter generic_update_force_string for cmd workloads sap-virtual-instance update
❌ 1007 - ParaRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update removed parameter generic_update_remove please add back parameter generic_update_remove for cmd workloads sap-virtual-instance update
❌ 1007 - ParaRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update removed parameter generic_update_set please add back parameter generic_update_set for cmd workloads sap-virtual-instance update
❌ 1007 - ParaRemove workloads sap-virtual-instance update cmd workloads sap-virtual-instance update removed parameter managed_resource_group_configuration please add back parameter managed_resource_group_configuration for cmd workloads sap-virtual-instance update
❌ 1010 - ParaPropUpdate workloads sap-virtual-instance update cmd workloads sap-virtual-instance update update parameter managed_resources_network_access_type: updated property options from ['--managed-resources-network-access-type', '--mrg-network-access-typ'] to ['--managed-resources-network-access-type'] please change property options from ['--managed-resources-network-access-type'] to ['--managed-resources-network-access-type', '--mrg-network-access-typ'] for parameter managed_resources_network_access_type of cmd workloads sap-virtual-instance update
⚠️ 1008 - ParaPropAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update update parameter managed_resources_network_access_type: added property aaz_default=Public
⚠️ 1008 - ParaPropAdd workloads sap-virtual-instance update cmd workloads sap-virtual-instance update update parameter managed_resources_network_access_type: added property default=Public

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Hi @jaskisin,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 4, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

@jaskisin jaskisin marked this pull request as ready for review September 4, 2024 09:18
@kairu-ms kairu-ms merged commit d0a0224 into Azure:main Sep 5, 2024
20 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 5, 2024

[Release] Update index.json for extension [ workloads ] : https://dev.azure.com/azclitools/release/_build/results?buildId=187134&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

Assignees

@jsntcy jsntcy

Labels
None yet
Projects
None yet
Milestone
September 2024 (2024-10-08)
Development

Successfully merging this pull request may close these issues.
5 participants
@jaskisin @yonzhan @azclibot @kairu-ms @jsntcy